fix fill/stroke order bug#2511
Merged
Merged
Conversation
Contributor
|
Great idea! The organization of that section of the code is a lot better now. I don't have an opportunity to investigate deeply. Can you just flag me in some way when you feel that this is ready for a merge? I can run through it then. |
Contributor
Author
|
oops, i forgot that i had to exclude the webgl examples from the tests, now that they're actually in the docs. should be good to go now, thx! |
Contributor
|
Cool so I just ran through a bunch of use scenarios and tests. I really like that this now falls in line with using _doFill/_doStroke along with the 2D renderer. Thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR:
shader.activeflag which was getting out of sync, and just uses the existing_doFill/_doStrokestyle properties instead.noFill/noStrokemethods.usePrograms